-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Cleanup includes #943
[JTC] Cleanup includes #943
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 46.86% 46.86%
=======================================
Files 41 41
Lines 3862 3862
Branches 1816 1816
=======================================
Hits 1810 1810
Misses 792 792
Partials 1260 1260
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c105cda
to
0750f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a good idea!
90e7703
to
7adf3ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet some of these come from older cppcheck errors, let's see how the backports will do! :D
(cherry picked from commit f14396c)
(cherry picked from commit f14396c)
(cherry picked from commit f14396c)
I cleaned-up the includes. It compiles and linters do not complain.
Fixes some items of #944