Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back pep257 docstring #4045

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Jan 10, 2024

Works when the "Returns" is added. I can't say I know why exactly though but my hypothesis is that for the style with Arg (without colon) the Returns section is mandatory 🤷‍♂️ . For other places with Args: (with colon), the Returns section is missing and the test doesn't complain

Signed-off-by: Tony Najjar <[email protected]>
.
Signed-off-by: Tony Najjar <[email protected]>
@SteveMacenski
Copy link
Member

what...the...fuck.... godIhatepython

Thank you so much :-)

@SteveMacenski SteveMacenski merged commit 370dbfd into ros-navigation:main Jan 10, 2024
9 of 11 checks passed
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
* test

Signed-off-by: Tony Najjar <[email protected]>

* .

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: enricosutera <[email protected]>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* test

Signed-off-by: Tony Najjar <[email protected]>

* .

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants