Adds the Nomad crash site to the rockplanet #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
spockye
suggested changes
Oct 4, 2023
There was a problem hiding this comment.
These are OBJ stairs, not turf stairs. they're used for Multi-z, and dont worm normally.
get what your going for, but im not sure it's such a good idea. i'll come back to you on this later.
WE HAVE PEBBLES?
(ULTRA NITPICK) Missing corner decal :)
mabye make a couple of the walls Rusted? just to spice it up
try to not leave corners like this. looks a bit off with out walls
this is a pretty ruin. good work!
This was referenced Oct 15, 2023
spockye
reviewed
Oct 16, 2023
spockye
suggested changes
Oct 20, 2023
Supports the Nomad Crash Ruin
spockye
approved these changes
Oct 27, 2023
Latentish
previously requested changes
Oct 28, 2023
|
Ruin does look cool though. |
Signed-off-by: spockye <[email protected]>
shiptest-server
pushed a commit
that referenced
this pull request
Oct 31, 2023
Mirag1993
added a commit
to ancientland/TestShiptest
that referenced
this pull request
Oct 31, 2023
Is the nomad a ship or a faction? I'll leave it to the lore junkies to decide down the line. Adds the Nomad Wreck to the ruin lineup of the Rock Planet.  Also repaths area/mine/rockplanet to area/ruin/rockplanet. The areas in this file weren't even being used so I might go back and actually make all the rockplanet ruin areas use this file later. All rockplanet ruins bar this new one currently use area/ruin/powered and area/overmap_encounter/planetoid/rockplanet for their areas. Using the default case of ruin/powered for all of your ruins isn't good practice. Finally adds a new ship manufacturer decal. I've been _illegally_ having fun brainstorming up an entire new lineup of ships. Furthermore, they = have garnered positive feedback from project managers in the official discord, so I'm confident in doing this here. This ruin is the first in a series of ruin addition that feature these vessels in an unflyable state. Be they wrecks, conversions, legitimate salvage, or otherwise. Introducing **Arrow & Axe** and their Dockyard subdivision. Hopefully a striking addition to the Shiptest universe!  I have been mapping for Shiptest all week, and my head is still full of a great deal many ideas! This is only the start so be on the lookout for more! Shoutout to @Imaginos16 for actually spriting out the crappy MSPAINT rendition of the logo. Excellent work as always! -Ruins are requested, so ruins shall be received. -New 7th ship manufacturer to add even more diversity to the game. This one is Military, so expect even more Spartan Vessels. ---Hammerhead vessel design, Flat-Bow profiles. Prominent nacelles and fishtale sterns. Interiors are asym. and biased port or stbd. (You'll see a complete one that's been converted into a salvage depot for my next PR). -New Ship manufacturer decal courtesy of @Imaginos16 to really drive that home. -Repathing the rockplanet.dmm areas out from under ../mine (and they were unused!) into ../ruin to bring it in line with everything else. :cl: add: New Rockplanet Ruin add: New ship manufacturer sprites. code: Repaths areas in rockplanet.dmm to be in line with other ruins. Starts using rockplanet.dmm. code: Code support for Arrow & Axe Dockyard sprites. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: spockye <[email protected]> Co-authored-by: spockye <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## turfs repathed this is mergable now thank you for waiting ## About The Pull Request #2384 Fixes the areas on nomadcrash and the two other rockplanet ruins that were given areas but never had them applied. Fixes the enemy selection on nomadcrash to better fit rockplanets mob pool. Repaths the turfs used in nomadcrash to be properly subtyped from their actual turfs and use rockplanet atmos.     ## Why It's Good For The Game Who merged this without checking it on a testmerge thoroughly? I just want to talk. Anyways ruins should probably use the correct areas and not have really fucky tiles. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: rockplanet_nomadcrash now uses the correct areas. fix: rockplanet_nomadcrash now uses correctly pathed turfs that dont break when spawned. fix: rockplanet_budgetcuts and rockplanet_miningexpedition now use their newly added respective areas instead of ruin/powered. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: zevo <[email protected]>
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Feb 28, 2024
…iptest-ss13#2448) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## turfs repathed this is mergable now thank you for waiting ## About The Pull Request shiptest-ss13#2384 Fixes the areas on nomadcrash and the two other rockplanet ruins that were given areas but never had them applied. Fixes the enemy selection on nomadcrash to better fit rockplanets mob pool. Repaths the turfs used in nomadcrash to be properly subtyped from their actual turfs and use rockplanet atmos.     ## Why It's Good For The Game Who merged this without checking it on a testmerge thoroughly? I just want to talk. Anyways ruins should probably use the correct areas and not have really fucky tiles. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: rockplanet_nomadcrash now uses the correct areas. fix: rockplanet_nomadcrash now uses correctly pathed turfs that dont break when spawned. fix: rockplanet_budgetcuts and rockplanet_miningexpedition now use their newly added respective areas instead of ruin/powered. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: zevo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is the nomad a ship or a faction? I'll leave it to the lore junkies to decide down the line.
About The Pull Request
Adds the Nomad Wreck to the ruin lineup of the Rock Planet.
Also repaths area/mine/rockplanet to area/ruin/rockplanet. The areas in this file weren't even being used so I might go back and actually make all the rockplanet ruin areas use this file later. All rockplanet ruins bar this new one currently use area/ruin/powered and area/overmap_encounter/planetoid/rockplanet for their areas. Using the default case of ruin/powered for all of your ruins isn't good practice.
Finally adds a new ship manufacturer decal. I've been illegally having fun brainstorming up an entire new lineup of ships. Furthermore, they = have garnered positive feedback from project managers in the official discord, so I'm confident in doing this here. This ruin is the first in a series of ruin addition that feature these vessels in an unflyable state. Be they wrecks, conversions, legitimate salvage, or otherwise. Introducing Arrow & Axe and their Dockyard subdivision. Hopefully a striking addition to the Shiptest universe!
I have been mapping for Shiptest all week, and my head is still full of a great deal many ideas! This is only the start so be on the lookout for more!
Shoutout to @Imaginos16 for actually spriting out the crappy MSPAINT rendition of the logo. Excellent work as always!
Why It's Good For The Game
-Ruins are requested, so ruins shall be received.
-New 7th ship manufacturer to add even more diversity to the game. This one is Military, so expect even more Spartan Vessels.
---Hammerhead vessel design, Flat-Bow profiles. Prominent nacelles and fishtale sterns. Interiors are asym. and biased port or stbd. (You'll see a complete one that's been converted into a salvage depot for my next PR).
-New Ship manufacturer decal courtesy of @Imaginos16 to really drive that home.
-Repathing the rockplanet.dmm areas out from under ../mine (and they were unused!) into ../ruin to bring it in line with everything else.
Changelog
🆑
add: New Rockplanet Ruin
add: New ship manufacturer sprites.
code: Repaths areas in rockplanet.dmm to be in line with other ruins. Starts using rockplanet.dmm.
code: Code support for Arrow & Axe Dockyard sprites.
/:cl: