Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x2_gen1_nebula): changed LiDAR driver to nebula #252

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

kotaro-hihara
Copy link

@kotaro-hihara kotaro-hihara commented Jul 8, 2024

Description

Changed LiDAR driver to nebula (removed hesai_pandar).
Adjusted Lidar Setting (FOV) and scan_phase to match nebula's scan cut specifications.

By this change, blockage_diag and dual_return_filter are no longer activated

Related Links

JIRA: TIER_IV_INTERNAL

@kotaro-hihara kotaro-hihara requested review from 0x126 and saka1-s July 8, 2024 06:32
@kotaro-hihara kotaro-hihara changed the title feat(/x2/gen1 nebula): changed LiDAR driver to nebula feat(x2_gen1_nebula): changed LiDAR driver to nebula Jul 8, 2024
<!--arg name="is_channel_order_top2down" value="true"/-->
<!--arg name="horizontal_resolution" value="0.4"/-->
<!--arg name="enable_blockage_diag" value="$(var enable_blockage_diag)"/-->
<!--arg name="calibration" value="$(find-pkg-share individual_params)/config/$(var vehicle_id)/aip_x2/pandar/front_lower.csv" /-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you stop passing the LiDAR intrinsic calibration file?

@0x126
Copy link
Contributor

0x126 commented Jul 9, 2024

@kotaro-hihara Is it intended that blockage_diag and dual_return_filter are no longer activated?

@kotaro-hihara kotaro-hihara merged commit c0ad3c4 into beta/v0.29.0 Jul 9, 2024
10 of 11 checks passed
@kotaro-hihara kotaro-hihara deleted the feat/x2/gen1-nebula branch July 9, 2024 01:40
@kotaro-hihara
Copy link
Author

@0x126 Yes, blockage_diag and dual_return_filter are no longer activated.

@0x126
Copy link
Contributor

0x126 commented Jul 9, 2024

@kotaro-hihara Since you changed the scan_phase, do you also need to change the time offset in concat?
https://github.com/tier4/aip_launcher/blob/tier4/universe/aip_x2_launch/launch/pointcloud_preprocessor.launch.py#L49

@kotaro-hihara
Copy link
Author

@0x126
Scan_phase change delayed 2.8msec (100*10/360) because the LEFT and FRONT publish were set back 10deg.
We would need to add [0.0,0.0,0.0,0.0,-0.0028,-0.0028,-0.0028,-0.0028,-0.0028,-0.0028] to the current settings, judging that it will have no significant effect, just waiting an extra 2.8msec for rear and right. So I have not changed it.

Autumn60 pushed a commit that referenced this pull request Sep 17, 2024
* change lidar driver to nebula from hesai

Signed-off-by: kotaro-hihara <[email protected]>

* Set scan_phase 10 deg behind ideal FOVend to prevent dust at the edge of FOV (left,front)

Signed-off-by: kotaro-hihara <[email protected]>

* ci(pre-commit): autofix

---------

Signed-off-by: kotaro-hihara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Autumn60 pushed a commit that referenced this pull request Sep 17, 2024
* change lidar driver to nebula from hesai

Signed-off-by: kotaro-hihara <[email protected]>

* Set scan_phase 10 deg behind ideal FOVend to prevent dust at the edge of FOV (left,front)

Signed-off-by: kotaro-hihara <[email protected]>

* ci(pre-commit): autofix

---------

Signed-off-by: kotaro-hihara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Autumn60 added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants