-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x2_gen1_nebula): changed LiDAR driver to nebula #252
Conversation
Signed-off-by: kotaro-hihara <[email protected]>
… of FOV (left,front) Signed-off-by: kotaro-hihara <[email protected]>
<!--arg name="is_channel_order_top2down" value="true"/--> | ||
<!--arg name="horizontal_resolution" value="0.4"/--> | ||
<!--arg name="enable_blockage_diag" value="$(var enable_blockage_diag)"/--> | ||
<!--arg name="calibration" value="$(find-pkg-share individual_params)/config/$(var vehicle_id)/aip_x2/pandar/front_lower.csv" /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you stop passing the LiDAR intrinsic calibration file?
@kotaro-hihara Is it intended that |
@0x126 Yes, blockage_diag and dual_return_filter are no longer activated. |
@kotaro-hihara Since you changed the |
@0x126 |
* change lidar driver to nebula from hesai Signed-off-by: kotaro-hihara <[email protected]> * Set scan_phase 10 deg behind ideal FOVend to prevent dust at the edge of FOV (left,front) Signed-off-by: kotaro-hihara <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: kotaro-hihara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* change lidar driver to nebula from hesai Signed-off-by: kotaro-hihara <[email protected]> * Set scan_phase 10 deg behind ideal FOVend to prevent dust at the edge of FOV (left,front) Signed-off-by: kotaro-hihara <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: kotaro-hihara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Changed LiDAR driver to nebula (removed hesai_pandar).
Adjusted Lidar Setting (FOV) and scan_phase to match nebula's scan cut specifications.
By this change, blockage_diag and dual_return_filter are no longer activated
Related Links
JIRA: TIER_IV_INTERNAL