Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(xx1_gen2): revert PR of updating for xx1 gen2 (#210) #280

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

zusizusi
Copy link
Contributor

@zusizusi zusizusi commented Aug 5, 2024

This reverts commit d1d423d.

This commmit included the activation of velodyne_hw_monitor. And I found that using velodyne_hw_monitor in a multi-threaded configuration would cause the node to crash.
Therefore, this commit is temporarily reverted.

@zusizusi zusizusi requested review from yukkysaito and shmpwk August 5, 2024 11:09
@zusizusi zusizusi changed the title revert(xx1_gen2): revert PR of update for xx1 gen2 (#210) revert(xx1_gen2): revert PR of updating for xx1 gen2 (#210) Aug 5, 2024
@zusizusi zusizusi merged commit cdf66b6 into beta/v0.29.0 Aug 5, 2024
11 of 12 checks passed
@zusizusi zusizusi deleted the tmp/v0.29.0/revert-pr-210 branch August 5, 2024 12:39
TomohitoAndo pushed a commit that referenced this pull request Aug 30, 2024
Revert "feat(aip_xx1_description): update for xx1 gen2 (#210)"

This reverts commit d1d423d.

Signed-off-by: Sho Iwasawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants