-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cut angle for left_upper and front_upper #349
Conversation
Signed-off-by: badai-nguyen <[email protected]>
As discussed in Slack, this will probably work fine because the LiDAR's resolution of 0.1 degrees is coarser than the set cut_angle with 0.01deg resolution. Thus, no points are expected to be between 359.99 and 360deg, and thus no points are expected to be forwarded to the next scan. As Nebula has not been evaluated with this workaround in mind, please know that this is not guaranteed to work. A safe fix would be to set |
If there is not a big issue to reduce FOV 1deg, I will change to @mojomex idea. |
Signed-off-by: badai-nguyen <[email protected]>
* fix: cut angle for left_upper and front_upper Signed-off-by: badai-nguyen <[email protected]> * chore: adjust cut angle Signed-off-by: badai-nguyen <[email protected]> * fix: make sure cut_angle equal max angle Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
https://star4.slack.com/archives/C07K9RBUQR3/p1732768812183349