Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

214 bug improve lidar point cloud quality #215

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

ll7
Copy link
Member

@ll7 ll7 commented Mar 12, 2024

Description

I forked the leaderboard repository to set the frame rate to 10 fps everywhere.
I changed the frame rates in the launch files.

Fixes #214 . Please check for results and documentation!!!

Type of change

Please delete options that are not relevant.

  • Bug fix
  • Breaking change
    • Only 10 fps
  • We no longer use the official code base from the leaderboard.

Does this PR introduce a breaking change?

  • 10 fps
  • leaderboard fork

Most important changes

Which files functionalities are most important in this PR. On which part should the reviewer be focussed on?

Are 10 fps sufficient? Acting is also affected. @hellschwalex

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@ll7 ll7 added bug Something isn't working perception planning acting labels Mar 12, 2024
@ll7 ll7 requested review from samuelkuehnel, MaxJa4 and okrusch March 12, 2024 16:41
@ll7 ll7 linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link

Simulation results

Metric Value
Avg. driving score 0.106484
Avg. route completion 0.315
Avg. infraction penalty 0.332528
Collisions with pedestrians 0.0
Collisions with vehicles 66.682
Collisions with layout 22.227
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.004
Route deviations 0.0
Route timeouts 0.0
Agent blocked 44.455
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.0
Min speed infractions 0.0

@okrusch okrusch merged commit 5ca3266 into main Mar 15, 2024
3 checks passed
@samuelkuehnel samuelkuehnel deleted the 214-bug-improve-lidar-point-cloud-quality branch April 1, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Improve Lidar point cloud quality
2 participants