Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #48 - Remove version tagging from build action #57

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[Fix] #48 - Remove version tagging from build action #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that Build and push Docker image and Output Version do not require any information from the removed action?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag was required to build and push the docker image. We reverted our last change and updated the permission for this job. As a test we merged this branch and the desired action ran without an error:

image

https://github.com/una-auxme/paf23/actions/runs/6881744045/job/18718772391

Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,6 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Bump version and push tag
# only run on push to main
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
id: tag
uses: mathieudutour/[email protected]
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
release_branches: main

- name: Get commit hash
id: hash
run: echo "hash=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
Expand Down
Loading