Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Unit Test Coverage #14931

Open
GuptaManan100 opened this issue Jan 10, 2024 · 10 comments · Fixed by #15028
Open

Improve Unit Test Coverage #14931

GuptaManan100 opened this issue Jan 10, 2024 · 10 comments · Fixed by #15028
Labels
Component: General Changes throughout the code base LFX Type: Testing

Comments

@GuptaManan100
Copy link
Member

GuptaManan100 commented Jan 10, 2024 •
edited by beingnoble03
Loading

Description

The unit test coverage of all the packages in Vitess need to be checked and improved upon.
We can look at https://app.codecov.io/gh/vitessio/vitess/tree/main for better guidance on which packages require testing.

List of all the packages in Vitess -

  • vitess/go
    • vitess/go/acl Add required tests for go/acl #14943
    • vitess/go/atomic2: tests: add tests for go/atomic2 #14975
    • vitess/go/bucketpool Add missing test for go/bucketpool #14944
    • vitess/go/bytes2
    • vitess/go/cache
      • vitess/go/cache/theine
        • vitess/go/cache/theine/bf
    • vitess/go/cmd
      • vitess/go/cmd/internal
        • vitess/go/cmd/internal/docgen
      • vitess/go/cmd/mysqlctl
        • vitess/go/cmd/mysqlctl/command
        • vitess/go/cmd/mysqlctl/docgen
      • vitess/go/cmd/mysqlctld
        • vitess/go/cmd/mysqlctld/cli
        • vitess/go/cmd/mysqlctld/docgen
      • vitess/go/cmd/rulesctl
        • vitess/go/cmd/rulesctl/cmd
        • vitess/go/cmd/rulesctl/common
      • vitess/go/cmd/topo2topo
        • vitess/go/cmd/topo2topo/cli
        • vitess/go/cmd/topo2topo/docgen
      • vitess/go/cmd/vtaclcheck
        • vitess/go/cmd/vtaclcheck/cli
        • vitess/go/cmd/vtaclcheck/docgen
      • vitess/go/cmd/vtadmin
      • vitess/go/cmd/vtbackup
        • vitess/go/cmd/vtbackup/cli
        • vitess/go/cmd/vtbackup/docgen
      • vitess/go/cmd/vtbench
        • vitess/go/cmd/vtbench/cli
        • vitess/go/cmd/vtbench/docgen
      • vitess/go/cmd/vtclient
        • vitess/go/cmd/vtclient/cli
        • vitess/go/cmd/vtclient/docgen
      • vitess/go/cmd/vtcombo
        • vitess/go/cmd/vtcombo/cli
        • vitess/go/cmd/vtcombo/docgen
      • vitess/go/cmd/vtctl
      • vitess/go/cmd/vtctlclient
      • vitess/go/cmd/vtctld
        • vitess/go/cmd/vtctld/cli
        • vitess/go/cmd/vtctld/docgen
      • vitess/go/cmd/vtctldclient
        • vitess/go/cmd/vtctldclient/cli
        • vitess/go/cmd/vtctldclient/command
          • vitess/go/cmd/vtctldclient/command/vreplication
            • vitess/go/cmd/vtctldclient/command/vreplication/common
            • vitess/go/cmd/vtctldclient/command/vreplication/lookupvindex
            • vitess/go/cmd/vtctldclient/command/vreplication/materialize
            • vitess/go/cmd/vtctldclient/command/vreplication/migrate
            • vitess/go/cmd/vtctldclient/command/vreplication/mount
            • vitess/go/cmd/vtctldclient/command/vreplication/movetables
            • vitess/go/cmd/vtctldclient/command/vreplication/reshard
            • vitess/go/cmd/vtctldclient/command/vreplication/vdiff
            • vitess/go/cmd/vtctldclient/command/vreplication/workflow
        • vitess/go/cmd/vtctldclient/docgen
      • vitess/go/cmd/vtexplain
        • vitess/go/cmd/vtexplain/cli
        • vitess/go/cmd/vtexplain/docgen
      • vitess/go/cmd/vtgate
        • vitess/go/cmd/vtgate/cli
        • vitess/go/cmd/vtgate/docgen
      • vitess/go/cmd/vtgateclienttest
        • vitess/go/cmd/vtgateclienttest/cli
        • vitess/go/cmd/vtgateclienttest/docgen
        • vitess/go/cmd/vtgateclienttest/services
      • vitess/go/cmd/vtorc
        • vitess/go/cmd/vtorc/cli
        • vitess/go/cmd/vtorc/docgen
      • vitess/go/cmd/vttablet
        • vitess/go/cmd/vttablet/cli
        • vitess/go/cmd/vttablet/docgen
      • vitess/go/cmd/vttestserver
        • vitess/go/cmd/vttestserver/cli
          • vitess/go/cmd/vttestserver/cli/data
            • vitess/go/cmd/vttestserver/cli/data/schema
              • vitess/go/cmd/vttestserver/cli/data/schema/app_customer
              • vitess/go/cmd/vttestserver/cli/data/schema/test_keyspace
        • vitess/go/cmd/vttestserver/docgen
      • vitess/go/cmd/vttlstest
        • vitess/go/cmd/vttlstest/cli
        • vitess/go/cmd/vttlstest/docgen
      • vitess/go/cmd/zk
      • vitess/go/cmd/zkctl
        • vitess/go/cmd/zkctl/command
        • vitess/go/cmd/zkctl/docgen
      • vitess/go/cmd/zkctld
        • vitess/go/cmd/zkctld/cli
        • vitess/go/cmd/zkctld/docgen
    • vitess/go/constants
      • vitess/go/constants/sidecar
    • vitess/go/errors
    • vitess/go/event
    • vitess/go/exit
    • vitess/go/fileutil
    • vitess/go/flags
      • vitess/go/flags/endtoend
    • vitess/go/flagutil
    • vitess/go/hack
    • vitess/go/history
    • vitess/go/internal
      • vitess/go/internal/flag
    • vitess/go/ioutil
    • vitess/go/json2 tests: add tests for go/json2 #14964
    • vitess/go/jsonutil
    • vitess/go/list
    • vitess/go/logstats
    • vitess/go/mathstats
    • vitess/go/mathutil: tests: add tests to go/mathutil #14969
    • vitess/go/mysql
      • vitess/go/mysql/binlog
      • vitess/go/mysql/capabilities
      • vitess/go/mysql/collations
        • vitess/go/mysql/collations/charset
          • vitess/go/mysql/collations/charset/eightbit
          • vitess/go/mysql/collations/charset/japanese
          • vitess/go/mysql/collations/charset/korean
          • vitess/go/mysql/collations/charset/simplifiedchinese
          • vitess/go/mysql/collations/charset/testdata
          • vitess/go/mysql/collations/charset/types
          • vitess/go/mysql/collations/charset/unicode
        • vitess/go/mysql/collations/colldata
        • vitess/go/mysql/collations/integration
          • vitess/go/mysql/collations/integration/testdata
            • vitess/go/mysql/collations/integration/testdata/mysqltest
              • vitess/go/mysql/collations/integration/testdata/mysqltest/suite
                • vitess/go/mysql/collations/integration/testdata/mysqltest/suite/collations
                  • vitess/go/mysql/collations/integration/testdata/mysqltest/suite/collations/include
        • vitess/go/mysql/collations/internal
          • vitess/go/mysql/collations/internal/uca
        • vitess/go/mysql/collations/remote
        • vitess/go/mysql/collations/testdata
          • vitess/go/mysql/collations/testdata/mysqldata
          • vitess/go/mysql/collations/testdata/versions
        • vitess/go/mysql/collations/testutil
        • vitess/go/mysql/collations/tools
          • vitess/go/mysql/collations/tools/colldump
          • vitess/go/mysql/collations/tools/makecolldata
            • vitess/go/mysql/collations/tools/makecolldata/codegen
          • vitess/go/mysql/collations/tools/maketestdata
        • vitess/go/mysql/collations/vindex
          • vitess/go/mysql/collations/vindex/collate
          • vitess/go/mysql/collations/vindex/internal
            • vitess/go/mysql/collations/vindex/internal/colltab
          • vitess/go/mysql/collations/vindex/unicode
            • vitess/go/mysql/collations/vindex/unicode/norm
      • vitess/go/mysql/config
      • vitess/go/mysql/datetime
        • vitess/go/mysql/datetime/testdata
      • vitess/go/mysql/decimal
        • vitess/go/mysql/decimal/testdata
      • vitess/go/mysql/endtoend
      • vitess/go/mysql/fakesqldb
      • vitess/go/mysql/fastparse
      • vitess/go/mysql/format
      • vitess/go/mysql/fuzzdata
      • vitess/go/mysql/hex: Add required tests for go/mysql/hex #14976
      • vitess/go/mysql/icuregex
        • vitess/go/mysql/icuregex/errors
        • vitess/go/mysql/icuregex/internal
          • vitess/go/mysql/icuregex/internal/bytestrie
          • vitess/go/mysql/icuregex/internal/icudata
          • vitess/go/mysql/icuregex/internal/normalizer
          • vitess/go/mysql/icuregex/internal/pattern
          • vitess/go/mysql/icuregex/internal/ubidi
          • vitess/go/mysql/icuregex/internal/ucase
          • vitess/go/mysql/icuregex/internal/uchar
          • vitess/go/mysql/icuregex/internal/udata
          • vitess/go/mysql/icuregex/internal/uemoji
          • vitess/go/mysql/icuregex/internal/ulayout
          • vitess/go/mysql/icuregex/internal/unames
          • vitess/go/mysql/icuregex/internal/uprops
          • vitess/go/mysql/icuregex/internal/uset
          • vitess/go/mysql/icuregex/internal/utf16
          • vitess/go/mysql/icuregex/internal/utrie
        • vitess/go/mysql/icuregex/testdata
      • vitess/go/mysql/json
      • vitess/go/mysql/ldapauthserver
      • vitess/go/mysql/replication
      • vitess/go/mysql/sqlerror
      • vitess/go/mysql/vault
    • vitess/go/netutil
    • vitess/go/pools
      • vitess/go/pools/smartconnpool
        • vitess/go/pools/smartconnpool/benchmarking
          • vitess/go/pools/smartconnpool/benchmarking/legacy
    • vitess/go/protoutil tests: add tests for go/protoutil/duration #14965
    • vitess/go/race
    • vitess/go/sets: unit test for go/sets/set.go #14973
    • vitess/go/slice
    • vitess/go/sqlescape: tests: add tests for go/sqlescape #14987
    • vitess/go/sqltypes
    • vitess/go/stats
      • vitess/go/stats/opentsdb
      • vitess/go/stats/prometheusbackend
      • vitess/go/stats/statsd
    • vitess/go/streamlog
    • vitess/go/sync2
    • vitess/go/syscallutil
    • vitess/go/tb
    • vitess/go/testfiles
    • vitess/go/textutil
    • vitess/go/timer
    • vitess/go/tools
      • vitess/go/tools/astfmtgen
      • vitess/go/tools/asthelpergen
        • vitess/go/tools/asthelpergen/integration
        • vitess/go/tools/asthelpergen/main
      • vitess/go/tools/ci-config
      • vitess/go/tools/codegen
      • vitess/go/tools/go-upgrade
      • vitess/go/tools/graphviz
      • vitess/go/tools/release-notes
        • vitess/go/tools/release-notes/integration
      • vitess/go/tools/releases
      • vitess/go/tools/sizegen
        • vitess/go/tools/sizegen/integration
    • vitess/go/trace
    • vitess/go/unicode2
    • vitess/go/viperutil
      • vitess/go/viperutil/debug
      • vitess/go/viperutil/funcs
      • vitess/go/viperutil/internal
        • vitess/go/viperutil/internal/log
        • vitess/go/viperutil/internal/registry
        • vitess/go/viperutil/internal/sync
        • vitess/go/viperutil/internal/value
      • vitess/go/viperutil/vipertest
    • vitess/go/vt
      • vitess/go/vt/binlog
        • vitess/go/vt/binlog/binlogplayer
        • vitess/go/vt/binlog/binlogplayertest
        • vitess/go/vt/binlog/eventtoken
        • vitess/go/vt/binlog/grpcbinlogplayer
        • vitess/go/vt/binlog/grpcbinlogstreamer
      • vitess/go/vt/callerid
        • vitess/go/vt/callerid/testsuite
      • vitess/go/vt/callinfo
        • vitess/go/vt/callinfo/fakecallinfo
      • vitess/go/vt/concurrency
      • vitess/go/vt/dbconfigs
      • vitess/go/vt/dbconnpool
      • vitess/go/vt/discovery
      • vitess/go/vt/dtids
      • vitess/go/vt/env
      • vitess/go/vt/events
      • vitess/go/vt/external
        • vitess/go/vt/external/golib
          • vitess/go/vt/external/golib/sqlutils
      • vitess/go/vt/graph
      • vitess/go/vt/grpcclient
      • vitess/go/vt/grpccommon
      • vitess/go/vt/grpcoptionaltls
      • vitess/go/vt/hook
      • vitess/go/vt/key
      • vitess/go/vt/log
      • vitess/go/vt/logutil
      • vitess/go/vt/logz
      • vitess/go/vt/mysqlctl
        • vitess/go/vt/mysqlctl/azblobbackupstorage
        • vitess/go/vt/mysqlctl/backupstats
        • vitess/go/vt/mysqlctl/backupstorage
        • vitess/go/vt/mysqlctl/cephbackupstorage
        • vitess/go/vt/mysqlctl/filebackupstorage
        • vitess/go/vt/mysqlctl/gcsbackupstorage
        • vitess/go/vt/mysqlctl/grpcmysqlctlclient
        • vitess/go/vt/mysqlctl/grpcmysqlctlserver
        • vitess/go/vt/mysqlctl/mysqlctlclient
        • vitess/go/vt/mysqlctl/mysqlctlproto
        • vitess/go/vt/mysqlctl/s3backupstorage
        • vitess/go/vt/mysqlctl/testdata
        • vitess/go/vt/mysqlctl/tmutils
      • vitess/go/vt/proto
        • vitess/go/vt/proto/binlogdata
        • vitess/go/vt/proto/binlogservice
        • vitess/go/vt/proto/logutil
        • vitess/go/vt/proto/mysqlctl
        • vitess/go/vt/proto/query
        • vitess/go/vt/proto/queryservice
        • vitess/go/vt/proto/replicationdata
        • vitess/go/vt/proto/tableacl
        • vitess/go/vt/proto/tabletmanagerdata
        • vitess/go/vt/proto/tabletmanagerservice
        • vitess/go/vt/proto/throttlerdata
        • vitess/go/vt/proto/throttlerservice
        • vitess/go/vt/proto/topodata
        • vitess/go/vt/proto/vschema
        • vitess/go/vt/proto/vtadmin
        • vitess/go/vt/proto/vtctldata
        • vitess/go/vt/proto/vtctlservice
        • vitess/go/vt/proto/vtgate
        • vitess/go/vt/proto/vtgateservice
        • vitess/go/vt/proto/vtrpc
        • vitess/go/vt/proto/vttest
        • vitess/go/vt/proto/vttime
        • vitess/go/vt/proto/workflow
      • vitess/go/vt/schema
      • vitess/go/vt/schemadiff
      • vitess/go/vt/schemamanager
      • vitess/go/vt/servenv
        • vitess/go/vt/servenv/internal
          • vitess/go/vt/servenv/internal/mux
        • vitess/go/vt/servenv/testutils
      • vitess/go/vt/sidecardb
        • vitess/go/vt/sidecardb/schema
          • vitess/go/vt/sidecardb/schema/misc
          • vitess/go/vt/sidecardb/schema/onlineddl
          • vitess/go/vt/sidecardb/schema/schemaengine
          • vitess/go/vt/sidecardb/schema/schematracker
          • vitess/go/vt/sidecardb/schema/twopc
          • vitess/go/vt/sidecardb/schema/vdiff
          • vitess/go/vt/sidecardb/schema/vreplication
      • vitess/go/vt/sqlparser
        • vitess/go/vt/sqlparser/goyacc
        • vitess/go/vt/sqlparser/optimizerhint
        • vitess/go/vt/sqlparser/testdata
      • vitess/go/vt/srvtopo
        • vitess/go/vt/srvtopo/srvtopotest
      • vitess/go/vt/sysvars
      • vitess/go/vt/tableacl
        • vitess/go/vt/tableacl/acl
        • vitess/go/vt/tableacl/simpleacl
        • vitess/go/vt/tableacl/testlib
      • vitess/go/vt/throttler
        • vitess/go/vt/throttler/demo
        • vitess/go/vt/throttler/grpcthrottlerserver
      • vitess/go/vt/tlstest
      • vitess/go/vt/topo
        • vitess/go/vt/topo/consultopo
        • vitess/go/vt/topo/etcd2topo
        • vitess/go/vt/topo/events
        • vitess/go/vt/topo/faketopo
        • vitess/go/vt/topo/helpers
        • vitess/go/vt/topo/memorytopo
        • vitess/go/vt/topo/test
        • vitess/go/vt/topo/topoproto
        • vitess/go/vt/topo/topotests
        • vitess/go/vt/topo/zk2topo
      • vitess/go/vt/topotools
        • vitess/go/vt/topotools/events
      • vitess/go/vt/vitessdriver
      • vitess/go/vt/vtaclcheck
      • vitess/go/vt/vtadmin
        • vitess/go/vt/vtadmin/cache
        • vitess/go/vt/vtadmin/cluster
          • vitess/go/vt/vtadmin/cluster/discovery
            • vitess/go/vt/vtadmin/cluster/discovery/fakediscovery
          • vitess/go/vt/vtadmin/cluster/dynamic
          • vitess/go/vt/vtadmin/cluster/internal
            • vitess/go/vt/vtadmin/cluster/internal/caches
              • vitess/go/vt/vtadmin/cluster/internal/caches/schemacache
          • vitess/go/vt/vtadmin/cluster/resolver
        • vitess/go/vt/vtadmin/credentials
        • vitess/go/vt/vtadmin/debug
        • vitess/go/vt/vtadmin/errors
        • vitess/go/vt/vtadmin/grpcserver
        • vitess/go/vt/vtadmin/http
          • vitess/go/vt/vtadmin/http/debug
          • vitess/go/vt/vtadmin/http/experimental
          • vitess/go/vt/vtadmin/http/handlers
        • vitess/go/vt/vtadmin/internal
          • vitess/go/vt/vtadmin/internal/backoff
          • vitess/go/vt/vtadmin/internal/rand
        • vitess/go/vt/vtadmin/rbac
          • vitess/go/vt/vtadmin/rbac/example
        • vitess/go/vt/vtadmin/sort
        • vitess/go/vt/vtadmin/testutil
          • vitess/go/vt/vtadmin/testutil/authztestgen
        • vitess/go/vt/vtadmin/vtadminproto
        • vitess/go/vt/vtadmin/vtctldclient
          • vitess/go/vt/vtadmin/vtctldclient/fakevtctldclient
        • vitess/go/vt/vtadmin/vtsql
          • vitess/go/vt/vtadmin/vtsql/fakevtsql
      • vitess/go/vt/vtcombo
      • vitess/go/vt/vtctl
        • vitess/go/vt/vtctl/endtoend
        • vitess/go/vt/vtctl/grpcclientcommon
        • vitess/go/vt/vtctl/grpcvtctlclient
        • vitess/go/vt/vtctl/grpcvtctldclient
        • vitess/go/vt/vtctl/grpcvtctldserver
          • vitess/go/vt/vtctl/grpcvtctldserver/endtoend
          • vitess/go/vt/vtctl/grpcvtctldserver/testutil
        • vitess/go/vt/vtctl/grpcvtctlserver
        • vitess/go/vt/vtctl/internal
          • vitess/go/vt/vtctl/internal/grpcshim
        • vitess/go/vt/vtctl/localvtctldclient
        • vitess/go/vt/vtctl/reparentutil
          • vitess/go/vt/vtctl/reparentutil/promotionrule
          • vitess/go/vt/vtctl/reparentutil/reparenttestutil
        • vitess/go/vt/vtctl/schematools
        • vitess/go/vt/vtctl/testdata
        • vitess/go/vt/vtctl/vtctlclient
        • vitess/go/vt/vtctl/vtctlclienttest
        • vitess/go/vt/vtctl/vtctldclient
          • vitess/go/vt/vtctl/vtctldclient/codegen
        • vitess/go/vt/vtctl/workflow
          • vitess/go/vt/vtctl/workflow/common
          • vitess/go/vt/vtctl/workflow/vexec
            • vitess/go/vt/vtctl/workflow/vexec/testutil
      • vitess/go/vt/vtctld
      • vitess/go/vt/vterrors
        • vitess/go/vt/vterrors/vterrorsgen
      • vitess/go/vt/vtexplain
        • vitess/go/vt/vtexplain/testdata
          • vitess/go/vt/vtexplain/testdata/multi-output
          • vitess/go/vt/vtexplain/testdata/twopc-output
      • vitess/go/vt/vtgate
        • vitess/go/vt/vtgate/buffer
        • vitess/go/vt/vtgate/endtoend
          • vitess/go/vt/vtgate/endtoend/deletetest
          • vitess/go/vt/vtgate/endtoend/update
        • vitess/go/vt/vtgate/engine
          • vitess/go/vt/vtgate/engine/opcode
        • vitess/go/vt/vtgate/errorsanitizer
        • vitess/go/vt/vtgate/evalengine
          • vitess/go/vt/vtgate/evalengine/integration
            • vitess/go/vt/vtgate/evalengine/integration/testdata
          • vitess/go/vt/vtgate/evalengine/testcases
        • vitess/go/vt/vtgate/fakerpcvtgateconn
        • vitess/go/vt/vtgate/grpcvtgateconn
        • vitess/go/vt/vtgate/grpcvtgateservice
        • vitess/go/vt/vtgate/logstats
        • vitess/go/vt/vtgate/planbuilder
          • vitess/go/vt/vtgate/planbuilder/operators
            • vitess/go/vt/vtgate/planbuilder/operators/fuzzdata
          • vitess/go/vt/vtgate/planbuilder/plancontext
          • vitess/go/vt/vtgate/planbuilder/testdata
            • vitess/go/vt/vtgate/planbuilder/testdata/vschemas
        • vitess/go/vt/vtgate/schema
        • vitess/go/vt/vtgate/semantics
          • vitess/go/vt/vtgate/semantics/bitset
        • vitess/go/vt/vtgate/simplifier
        • vitess/go/vt/vtgate/testdata
        • vitess/go/vt/vtgate/vindexes
          • vitess/go/vt/vtgate/vindexes/testdata
        • vitess/go/vt/vtgate/vschemaacl
        • vitess/go/vt/vtgate/vtgateconn
        • vitess/go/vt/vtgate/vtgateservice
      • vitess/go/vt/vthash
        • vitess/go/vt/vthash/highway
        • vitess/go/vt/vthash/metro
      • vitess/go/vt/vtorc
        • vitess/go/vt/vtorc/collection
        • vitess/go/vt/vtorc/config
        • vitess/go/vt/vtorc/db
        • vitess/go/vt/vtorc/discovery
        • vitess/go/vt/vtorc/inst
        • vitess/go/vt/vtorc/logic
        • vitess/go/vt/vtorc/metrics
          • vitess/go/vt/vtorc/metrics/query
        • vitess/go/vt/vtorc/process
        • vitess/go/vt/vtorc/server
        • vitess/go/vt/vtorc/test
        • vitess/go/vt/vtorc/util
      • vitess/go/vt/vttablet
        • vitess/go/vt/vttablet/customrule
          • vitess/go/vt/vttablet/customrule/filecustomrule
          • vitess/go/vt/vttablet/customrule/topocustomrule
        • vitess/go/vt/vttablet/endtoend
          • vitess/go/vt/vttablet/endtoend/connkilling
          • vitess/go/vt/vttablet/endtoend/framework
          • vitess/go/vt/vttablet/endtoend/streamtimeout
        • vitess/go/vt/vttablet/faketmclient
        • vitess/go/vt/vttablet/filelogger
        • vitess/go/vt/vttablet/grpcqueryservice
        • vitess/go/vt/vttablet/grpctabletconn
        • vitess/go/vt/vttablet/grpctmclient
        • vitess/go/vt/vttablet/grpctmserver
        • vitess/go/vt/vttablet/onlineddl
          • vitess/go/vt/vttablet/onlineddl/vrepl
        • vitess/go/vt/vttablet/queryservice
          • vitess/go/vt/vttablet/queryservice/fakes
        • vitess/go/vt/vttablet/sandboxconn
        • vitess/go/vt/vttablet/sysloglogger
        • vitess/go/vt/vttablet/tabletconn
        • vitess/go/vt/vttablet/tabletconntest
        • vitess/go/vt/vttablet/tabletmanager
          • vitess/go/vt/vttablet/tabletmanager/events
          • vitess/go/vt/vttablet/tabletmanager/vdiff
          • vitess/go/vt/vttablet/tabletmanager/vreplication
            • vitess/go/vt/vttablet/tabletmanager/vreplication/queryhistory
        • vitess/go/vt/vttablet/tabletserver
          • vitess/go/vt/vttablet/tabletserver/connpool
          • vitess/go/vt/vttablet/tabletserver/gc
          • vitess/go/vt/vttablet/tabletserver/heartbeat
          • vitess/go/vt/vttablet/tabletserver/messager
          • vitess/go/vt/vttablet/tabletserver/planbuilder
            • vitess/go/vt/vttablet/tabletserver/planbuilder/testdata
          • vitess/go/vt/vttablet/tabletserver/repltracker
          • vitess/go/vt/vttablet/tabletserver/rules
          • vitess/go/vt/vttablet/tabletserver/schema
            • vitess/go/vt/vttablet/tabletserver/schema/schematest
          • vitess/go/vt/vttablet/tabletserver/tabletenv
            • vitess/go/vt/vttablet/tabletserver/tabletenv/tabletenvtest
          • vitess/go/vt/vttablet/tabletserver/throttle
            • vitess/go/vt/vttablet/tabletserver/throttle/base
            • vitess/go/vt/vttablet/tabletserver/throttle/config
            • vitess/go/vt/vttablet/tabletserver/throttle/mysql
            • vitess/go/vt/vttablet/tabletserver/throttle/throttlerapp
          • vitess/go/vt/vttablet/tabletserver/tx
          • vitess/go/vt/vttablet/tabletserver/txlimiter
          • vitess/go/vt/vttablet/tabletserver/txserializer
          • vitess/go/vt/vttablet/tabletserver/txthrottler
          • vitess/go/vt/vttablet/tabletserver/vstreamer
            • vitess/go/vt/vttablet/tabletserver/vstreamer/testenv
        • vitess/go/vt/vttablet/tabletservermock
        • vitess/go/vt/vttablet/tmclient
        • vitess/go/vt/vttablet/tmclienttest
        • vitess/go/vt/vttablet/tmrpctest
      • vitess/go/vt/vttest
      • vitess/go/vt/vttls
      • vitess/go/vt/wrangler
        • vitess/go/vt/wrangler/testdata
        • vitess/go/vt/wrangler/testlib
      • vitess/go/vt/zkctl
    • vitess/go/vtbench
    • vitess/go/yaml2
    • vitess/go/zk
      • vitess/go/zk/zkctl
@GuptaManan100 GuptaManan100 added Type: Testing LFX Component: General Changes throughout the code base labels Jan 10, 2024
@mattlord
Copy link
Contributor

This is related to: #14932

@mattlord mattlord mentioned this issue Jan 10, 2024
Open
@beingnoble03
Copy link
Member

Can you please assign me vitess/go/acl?

@GuptaManan100
Copy link
Member Author

GuptaManan100 commented Jan 11, 2024 •
edited
Loading

@beingnoble03 You can start working on it. When you create a PR, just mention this issue, so that if anyone else looks they know you're working on the said part.

@beingnoble03
Copy link
Member

@GuptaManan100 sure, thanks.

@glokta1 glokta1 mentioned this issue Jan 12, 2024
Merged
5 tasks
@rajivharlalka rajivharlalka mentioned this issue Jan 13, 2024
Merged
5 tasks
@rajivharlalka
Copy link
Contributor

rajivharlalka commented Jan 13, 2024 •
edited
Loading

@GuptaManan100 I was trying to understand the number of LFX mentee's that is proposed to be taken for the upcoming term? Is it just 1 or multiple people would be participating in different parts of the project?

This was referenced Jan 13, 2024
Merged
Merged
@frouioui
Copy link
Member

frouioui commented Jan 15, 2024 •
edited
Loading

On #14935 we have seen that the coverage of planbuilder is not being reported. On the base branch it is reported as 0.00% which leads to Code coverage failure as soon as we modify the lines in this package and subpackages.

@ChaitanyaD48 ChaitanyaD48 mentioned this issue Jan 15, 2024
Merged
5 tasks
@EshaanAgg EshaanAgg mentioned this issue Jan 16, 2024
Merged
5 tasks
@EshaanAgg
Copy link
Contributor

EshaanAgg commented Jan 16, 2024 •
edited
Loading

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm?
image

@EshaanAgg EshaanAgg mentioned this issue Jan 16, 2024
Merged
5 tasks
@ChaitanyaD48 ChaitanyaD48 mentioned this issue Jan 16, 2024
Merged
5 tasks
This was referenced Jan 16, 2024
Merged
Merged
@frouioui
Copy link
Member

frouioui commented Jan 16, 2024 •
edited
Loading

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm?

@EshaanAgg, @GuptaManan100 is OOO, but I can confirm that it already has 100% of coverage on main, see the link below.

https://app.codecov.io/gh/vitessio/vitess/tree/main/go%2Fhistory

@Maniktherana Maniktherana mentioned this issue Jan 16, 2024
Merged
5 tasks
@EshaanAgg EshaanAgg mentioned this issue Jan 16, 2024
Merged
5 tasks
@Its-Maniaco Its-Maniaco mentioned this issue Jan 17, 2024
Merged
@Maniktherana Maniktherana mentioned this issue Jan 17, 2024
Closed
5 tasks
@beingnoble03 beingnoble03 mentioned this issue Jan 17, 2024
Merged
5 tasks
@Maniktherana Maniktherana mentioned this issue Jan 18, 2024
Closed
5 tasks
@beingnoble03 beingnoble03 mentioned this issue Jan 18, 2024
Merged
5 tasks
@Maniktherana Maniktherana mentioned this issue Jan 18, 2024
Merged
5 tasks
@Maniktherana Maniktherana mentioned this issue Jan 27, 2024
Closed
5 tasks
This was referenced Jan 28, 2024
Merged
Merged
@beingnoble03 beingnoble03 mentioned this issue Jan 28, 2024
Merged
5 tasks
@VaibhavMalik4187 VaibhavMalik4187 mentioned this issue Jan 28, 2024
Merged
5 tasks
VaibhavMalik4187 added a commit to VaibhavMalik4187/vitess that referenced this issue Jan 29, 2024
@VaibhavMalik4187
Added unit tests for the constants/sidecar package
4b81cb9 
This commit increases the code coverage of the `go/constants` package to
100%

Partially addresses: vitessio#14931

Signed-off-by: VaibhavMalik4187 <[email protected]>
@beingnoble03 beingnoble03 mentioned this issue Jan 29, 2024
Merged
5 tasks
@VaibhavMalik4187 VaibhavMalik4187 mentioned this issue Jan 29, 2024
Merged
5 tasks
This was referenced Jan 31, 2024
Closed
Closed
@Manni-99 Manni-99 mentioned this issue Feb 4, 2024
Merged
5 tasks
VaibhavMalik4187 added a commit to VaibhavMalik4187/vitess that referenced this issue Feb 7, 2024
@VaibhavMalik4187
Added unit tests for go/cmd/rulesctl/ package
9623a8f 
This commit increases the code coverage of the `cmd/rulesctl/common`
package to 71% and that of `cmd/rulesctl/cmd` package to >90%

Partially Fixes: vitessio#14931

Signed-off-by: VaibhavMalik4187 <[email protected]>
@beingnoble03 beingnoble03 mentioned this issue Feb 13, 2024
Merged
5 tasks
This was referenced Mar 1, 2024
Merged
Merged
@GuptaManan100 GuptaManan100 reopened this Mar 5, 2024
This was referenced Mar 11, 2024
Merged
Merged
This was referenced Mar 27, 2024
Merged
Merged
This was referenced Apr 6, 2024
Merged
Merged
@beingnoble03 beingnoble03 mentioned this issue Apr 25, 2024
Merged
5 tasks
This was referenced May 8, 2024
Merged
Merged
@beingnoble03
Copy link
Member

beingnoble03 commented May 9, 2024 •
edited
Loading

@GuptaManan100 I've removed go/maps2 and added go/logstats from the PR description as we don't have maps2 anymore, and logstats wasn't listed.

This was referenced May 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: General Changes throughout the code base LFX Type: Testing
Projects
None yet
Milestone
No milestone
7 participants
@mattlord @frouioui @GuptaManan100 @beingnoble03 @rajivharlalka @verma-kunal @EshaanAgg