-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client)!: Remove request wrappers - KvClient::put #882
Conversation
@lxl66566 Convert your pr to draft since CI failed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 75.55% 75.71% +0.16%
==========================================
Files 180 189 +9
Lines 26938 28666 +1728
Branches 26938 28666 +1728
==========================================
+ Hits 20353 21705 +1352
- Misses 5366 5635 +269
- Partials 1219 1326 +107 ☔ View full report in Codecov by Sentry. |
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
85d5154
to
9e6b057
Compare
@lxl66566 Convert your pr to draft since CI failed |
414a1dc
to
8ba81e7
Compare
@lxl66566 Convert your pr to draft since CI failed |
a1ee77e
to
1e3bc13
Compare
1e3bc13
to
c3f08ad
Compare
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
clients/kv.rs
fromfn put(&self, request: PutRequest)
toput(&self, key: impl Into<Vec<u8>>, value: impl Into<Vec<u8>>, option: Option<PutOptions>)
types::PutRequest
totypes::PutOptions
, made it an option for put function. The option will be combined with key and value to axlineapi::PutRequest
inside theKvClient.put()
function.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
put()
function thoughtout the crate.