Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Baro: remove unnecessary "#ifdef HAL_BUILD_AP_PERIPH" #27981

Merged
merged 1 commit into from
Sep 4, 2024
Merged

AP_Baro: remove unnecessary "#ifdef HAL_BUILD_AP_PERIPH" #27981

merged 1 commit into from
Sep 4, 2024

Conversation

junan76
Copy link
Contributor

@junan76 junan76 commented Sep 2, 2024 •
edited
Loading

Since there are already two implementations of the "healthy" method in file "AP_Baro.cpp", and they are both with clear comments, I think that "#ifdef" thing should be removed from the header file :P

peterbarker
peterbarker requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Nice cleanup!

libraries/AP_Baro/AP_Baro.h Outdated Show resolved Hide resolved
@junan76 junan76 force-pushed the dev branch 2 times, most recently from d920a51 to c15b8aa Compare September 3, 2024 01:23
@junan76 junan76 requested a review from peterbarker September 3, 2024 01:26
peterbarker
peterbarker approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker
Copy link
Contributor 

Board,AP_Periph,blimp,bootloader,copter,heli,plane,rover,sub
Durandal,,*,*,*,*,*,*,*
Hitec-Airspeed,*,,,,,,,
KakuteH7-bdshot,,*,*,*,*,*,*,*
MatekF405,,*,*,*,*,*,*,*
f103-QiotekPeriph,*,,,,,,,
f303-Universal,*,,,,,,,

@junan76 @peterbarker
AP_Baro: remove unnecessary "#ifdef HAL_BUILD_AP_PERIPH"
3951e7d 
Signed-off-by: junan <[email protected]>

AP_Baro: Update libraries/AP_Baro/AP_Baro.h suggested by @peterbarker

Co-authored-by: Peter Barker <[email protected]>
@rmackay9 rmackay9 merged commit 4e1ef8e into ArduPilot:master Sep 4, 2024
93 checks passed
@junan76 junan76 deleted the dev branch September 4, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junan76 @peterbarker @rmackay9