Center circle detection + calibration integration #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxbotix
force-pushed
the
2024-09_complete_camera_calibration_integration
branch
from
5923456 to
401b907
Compare
1 task
Minimum distance between three points of circle ransac is enforced WIP filtering Remove unused components and have a more "functional" interface. Additional outputs are ready Add cycle instance to the additional outputs Initial work to get line detection debug images into twix Can visualise the intermediate stages of line detection via twix. Get some crude timing Resize image for easier debug Fixed the resizing Parameters for fast debugging Faster processing setup View filtered calibration lines Filter points by horizon
Make the cycler to work WIP tuning
Cleaning up & clippifying Refactored the cycler Render edge points Use image segments as an alternative source of edge points updated score calculation scheme and random generator change to ChaCha Sub-sampling for faster search (= more iterations per search can be done)
Edge detection crate
Downgrade stuff & fix transitive dependency issue
Rename parameters and struct members. Update the twix panel to work properly Clippy fixes
tuxbotix
force-pushed
the
2024-09_complete_camera_calibration_integration
branch
from
401b907 to
4981fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
As the title says, should supercede #1057
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Describe how to test your changes. (For the reviewer)