Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Armor #3660

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Character Armor #3660

merged 2 commits into from
Oct 15, 2024

Conversation

ven1883
Copy link
Collaborator

@ven1883 ven1883 commented Oct 3, 2024

you can do the thing

About The Pull Request

I realized while trying to add armor to martial arts owners that the only two ways of changing a character's armor was with physiology.armor and clothing, unless you count "other" methods.
This change allows you to use "set_armor()" on /carbon/human to give them armor.

Should also fix several random items throughout the codebase, nanites will certainly be affected.

Why It's Good For The Game

This just fixes a bug that we have had for a LONG time, given the last time this code was touched was 2 years ago.

Changelog

🆑
fix: character and inherent armor have been fixed. unknown how many things this will affect, but includes nanite armor
code: modified carbon/human/proc/check_armor() to check src.armor during calculations
code: you can now use "set_armor" on human subtypes
refactor: for people using debuggers, you can watch "inherent_armor_rating" to see the inherent armor stats of a character being damaged.
refactor: uses / 100 instead of * 0.01. No change in function as far as I know
/:cl:

you can do the thing
@ven1883
Copy link
Collaborator Author

ven1883 commented Oct 3, 2024

i will convert the ternary to an if/else in a moment

@ven1883 ven1883 closed this Oct 3, 2024
@ven1883 ven1883 deleted the inherent-armor branch October 3, 2024 20:58
@ven1883 ven1883 restored the inherent-armor branch October 3, 2024 20:58
@ven1883 ven1883 reopened this Oct 3, 2024
@ven1883
Copy link
Collaborator Author

ven1883 commented Oct 3, 2024

i may be a little stupid

@ven1883
Copy link
Collaborator Author

ven1883 commented Oct 3, 2024

because TGUI I can no longer run the server, so if you want an if/else statement, you can either wait until I get internet beyond a cell hotspot, or you can go for it yourself

This was referenced Oct 9, 2024
@Absolucy Absolucy merged commit 7e2fa0e into Monkestation:master Oct 15, 2024
24 checks passed
github-actions bot added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants