-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character Armor #3660
Merged
Merged
Character Armor #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can do the thing
i will convert the ternary to an if/else in a moment |
i may be a little stupid |
because TGUI I can no longer run the server, so if you want an if/else statement, you can either wait until I get internet beyond a cell hotspot, or you can go for it yourself |
This was referenced Oct 4, 2024
Closed
This was referenced Oct 6, 2024
Closed
This was referenced Oct 7, 2024
Closed
This was referenced Oct 9, 2024
Open
Open
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can do the thing
About The Pull Request
I realized while trying to add armor to martial arts owners that the only two ways of changing a character's armor was with physiology.armor and clothing, unless you count "other" methods.
This change allows you to use "set_armor()" on /carbon/human to give them armor.
Should also fix several random items throughout the codebase, nanites will certainly be affected.
Why It's Good For The Game
This just fixes a bug that we have had for a LONG time, given the last time this code was touched was 2 years ago.
Changelog
🆑
fix: character and inherent armor have been fixed. unknown how many things this will affect, but includes nanite armor
code: modified carbon/human/proc/check_armor() to check src.armor during calculations
code: you can now use "set_armor" on human subtypes
refactor: for people using debuggers, you can watch "inherent_armor_rating" to see the inherent armor stats of a character being damaged.
refactor: uses / 100 instead of * 0.01. No change in function as far as I know
/:cl: