config: addresses and signatures for sushiswap dex agg #818
Conversation
WalkthroughThis pull request introduces modifications to two configuration files: Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test Coverage ReportLine Coverage: 78.39% (1695 / 2162 lines) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- config/dexs.json (18 hunks)
- config/sigs.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- config/sigs.json
🧰 Additional context used
🪛 Biome
config/dexs.json
[error] 458-458: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
[error] 657-657: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
🔇 Additional comments (11)
config/dexs.json (11)
461-463: New addresses added to Metis configuration. Please verify.The following new addresses have been added to the Metis configuration:
- 0x27f0e36dE6B1BA8232f6c2e87E00A50731048C6B
- 0xB45e53277a7e0F1D35f2a77160e91e25507f1763
271-273:⚠️ Potential issueAddress duplication in Celo configuration. Please remove the duplicate.
New addresses have been added to the Celo configuration, but there's a duplication:
- 0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959 appears on both line 271 and line 272.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc", "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", - "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
#!/bin/bash # Verify the legitimacy of the new addresses for address in 0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55 do echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt" done
205-209: New addresses added to Boba configuration. Please verify.The following new addresses have been added to the Boba configuration:
- 0xB45e53277a7e0F1D35f2a77160e91e25507f1763
- 0x80C7DD17B01855a6D2347444a0FCC36136a314de
- 0xbe811a0d44e2553d25d11cb8dc0d3f0d0e6430e6
- 0xe43ca1Dee3F0fc1e2df73A0745674545F11A59F5
- 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55
These additions look consistent with the existing format. However, please ensure that these addresses are correct and represent legitimate DEX contracts or related components for the Boba network.
Note: The address 0xe43ca1Dee3F0fc1e2df73A0745674545F11A59F5 is also present in the mainnet section. While this is not necessarily an issue, as different networks can have the same contract addresses, please confirm that this is intentional.
#!/bin/bash # Verify the legitimacy of the new addresses for address in 0xB45e53277a7e0F1D35f2a77160e91e25507f1763 0x80C7DD17B01855a6D2347444a0FCC36136a314de 0xbe811a0d44e2553d25d11cb8dc0d3f0d0e6430e6 0xe43ca1Dee3F0fc1e2df73A0745674545F11A59F5 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55 do echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt" done
247-251:⚠️ Potential issueAddress duplication in BSC configuration. Please remove the duplicate.
New addresses have been added to the BSC configuration, but there's a duplication:
- 0x33d91116e0370970444B0281AB117e161fEbFcdD appears on both line 34 and line 250.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x0000000000001ff3684f28c67538d4d072c22734", "0x7cf167390E2526Bc03F3CF6852A7AF1CEC3e243d", "0x400d75dAb26bBc18D163AEA3e83D9Ea68F6c1804", - "0x33d91116e0370970444B0281AB117e161fEbFcdD", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
#!/bin/bash # Verify the legitimacy of the new addresses for address in 0x0000000000001ff3684f28c67538d4d072c22734 0x7cf167390E2526Bc03F3CF6852A7AF1CEC3e243d 0x400d75dAb26bBc18D163AEA3e83D9Ea68F6c1804 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55 do echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt" done
457-457: New address added to Mantle configuration. Please verify.A new address has been added to the Mantle configuration:
- 0x6131b5fae19ea4f9d964eac0408e4408b66337b5
This addition looks consistent with the existing format. However, please ensure that this address is correct and represents a legitimate DEX contract or related component for the Mantle network.
#!/bin/bash # Verify the legitimacy of the new address address="0x6131b5fae19ea4f9d964eac0408e4408b66337b5" echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt"
355-359:⚠️ Potential issueAddress duplication in Fuse configuration. Please remove the duplicate.
New addresses have been added to the Fuse configuration, but there's a duplication:
- 0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e appears on both line 355 and line 358.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e", "0x1be211D8DA40BC0ae8719c6663307Bfc987b1d6c", "0xaa26771d497814E81D305c511Efbb3ceD90BF5bd", - "0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
#!/bin/bash # Verify the legitimacy of the new addresses for address in 0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e 0x1be211D8DA40BC0ae8719c6663307Bfc987b1d6c 0xaa26771d497814E81D305c511Efbb3ceD90BF5bd 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55 do echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt" done
385-389:⚠️ Potential issueAddress duplication in Gnosis configuration. Please remove the duplicate.
New addresses have been added to the Gnosis configuration, but there's a duplication:
- 0x46b3fdf7b5cde91ac049936bf0bdb12c5d22202e appears on both line 23 and line 388.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x111111125421ca6dc452d289314280a0f8842a65", "0x1e9B24073183d5c6B7aE5FB4b8f0b1dd83FDC77a", "0xBBDe1d67297329148Fe1ED5e6B00114842728e65", - "0x46b3fdf7b5cde91ac049936bf0bdb12c5d22202e", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
#!/bin/bash # Verify the legitimacy of the new addresses for address in 0x111111125421ca6dc452d289314280a0f8842a65 0x1e9B24073183d5c6B7aE5FB4b8f0b1dd83FDC77a 0xBBDe1d67297329148Fe1ED5e6B00114842728e65 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55 do echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt" done
183-185:⚠️ Potential issueAddress duplication in Blast configuration. Please remove the duplicate.
New addresses have been added to the Blast configuration, but there's a duplication:
- 0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959 appears on both line 8 and line 184.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0xcdbcd51a5e8728e0af4895ce5771b7d17ff71959", "0x0000000000001ff3684f28c67538d4d072c22734", - "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
82-86:⚠️ Potential issueAddress duplication in Arbitrum configuration. Please remove the duplicate.
New addresses have been added to the Arbitrum configuration, but there's a duplication:
- 0x544bA588efD839d2692Fc31EA991cD39993c135F appears on both line 32 and line 85.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x544bA588efD839d2692Fc31EA991cD39993c135F", "0x111111125421ca6dc452d289314280a0f8842a65", "0xdef171fe48cf0115b1d80b88dc8eab59176fee57", "0x6a000f20005980200259b80c5102003040001068", "0x216b4b4ba9f3e719726886d34a177484278bfcae", "0x0000000000001ff3684f28c67538d4d072c22734", "0x9c6522117e2ed1fE5bdb72bb0eD5E3f2bdE7DBe0", "0xfc506AaA1340b4dedFfd88bE278bEe058952D674", - "0x544bA588efD839d2692Fc31EA991cD39993c135F", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
170-172:⚠️ Potential issueAddress duplication in Base configuration. Please remove the duplicate.
New addresses have been added to the Base configuration, but there's a duplication:
- 0x0389879e0156033202c44bf784ac18fc02edee4f appears on both line 15 and line 171.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x93aaae79a53759cd164340e4c8766e4db5331cd7", "0x0000000000001ff3684f28c67538d4d072c22734", - "0x0389879e0156033202c44bf784ac18fc02edee4f", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
335-339:⚠️ Potential issueAddress duplication in Fantom configuration. Please remove the duplicate.
New addresses have been added to the Fantom configuration, but there's a duplication:
- 0x46b3fdf7b5cde91ac049936bf0bdb12c5d22202e appears on both line 26 and line 338.
Please remove one instance of this address to avoid confusion and potential issues.
Apply this diff to remove the duplicate address:
"0x111111125421ca6dc452d289314280a0f8842a65", "0x3D2f8ae0344d38525d2AE96Ab750B83480c0844F", "0x2214A42d8e2A1d20635c2cb0664422c528B6A432", - "0x46b3fdf7b5cde91ac049936bf0bdb12c5d22202e", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",Also, please verify the legitimacy of the new addresses added to this section.
✅ Verification successful
Duplicate Ethereum address found exclusively in
config/dexs.json. Please remove the redundant entry.After verifying the new Ethereum addresses, the duplicated address
0x46b3fdf7b5cde91ac049936bf0bdb12c5d22202eappears solely withinconfig/dexs.jsonand is not referenced elsewhere in the codebase.Removing the duplicate will eliminate potential confusion and maintain the integrity of the configuration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the legitimacy of the new addresses for address in 0x111111125421ca6dc452d289314280a0f8842a65 0x3D2f8ae0344d38525d2AE96Ab750B83480c0844F 0x2214A42d8e2A1d20635c2cb0664422c528B6A432 0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55 do echo "Checking $address:" # Search for any references to the address in the codebase rg -i "$address" --type md --type txt # Check if the address is mentioned in any official documentation or comments rg -i "$address" -g "*.md" -g "*.txt" doneLength of output: 1791
Script:
#!/bin/bash # Verify the legitimacy of the new addresses by searching across all source code files addresses=( "0x111111125421ca6dc452d289314280a0f8842a65" "0x3D2f8ae0344d38525d2AE96Ab750B83480c0844F" "0x2214A42d8e2A1d20635c2cb0664422c528B6A432" "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" ) for address in "${addresses[@]}" do echo "Checking $address in source code files:" rg -i "$address" --type js --type ts --type json --type jsx --type tsx --type vue doneLength of output: 1537
Script:
#!/bin/bash # Verify the legitimacy of the new addresses by searching across all relevant source code files addresses=( "0x111111125421ca6dc452d289314280a0f8842a65" "0x3D2f8ae0344d38525d2AE96Ab750B83480c0844F" "0x2214A42d8e2A1d20635c2cb0664422c528B6A432" "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" ) for address in "${addresses[@]}" do echo "Checking $address in source code files:" rg -i "$address" -g "*.js" -g "*.ts" -g "*.json" -g "*.jsx" -g "*.tsx" -g "*.vue" doneLength of output: 3567
There was a problem hiding this comment.
Actionable comments posted: 13
🧹 Outside diff range and nitpick comments (1)
config/dexs.json (1)
Line range hint
1-756: Consider adding newlines between network sections for improved readability.The overall structure of the file is correct and consistent. However, to improve readability, consider adding empty lines between each network section. This will make it easier to visually distinguish between different networks.
For example:
"mainnet": [ ... ], "arbitrum": [ ... ], "aurora": [ ... ],🧰 Tools
🪛 Biome
[error] 657-657: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
[error] 667-667: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- config/dexs.json (18 hunks)
- config/sigs.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- config/sigs.json
🧰 Additional context used
🪛 Biome
config/dexs.json
[error] 458-458: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
[error] 657-657: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
🔇 Additional comments (5)
config/dexs.json (5)
39-43: LGTM: New mainnet addresses added correctly.The new addresses for the mainnet have been added in the correct format and appear to be valid Ethereum addresses. There are no obvious duplicates or formatting issues.
205-209: LGTM: New boba addresses added correctly.The new addresses for the Boba network have been added in the correct format and appear to be valid Ethereum addresses. There are no obvious duplicates or formatting issues.
457-457: LGTM: New mantle address added correctly.The new address for the Mantle network has been added in the correct format and appears to be a valid Ethereum address. There are no obvious duplicates or formatting issues.
461-463: LGTM: New metis addresses added correctly.The new addresses for the Metis network have been added in the correct format and appear to be valid Ethereum addresses. There are no obvious duplicates or formatting issues.
458-458: Static analysis warnings appear to be false positives.The static analysis tool Biome reported parse errors on lines 458 and 657, suggesting unexpected closing brackets. However, upon manual inspection, the JSON structure appears to be correct, and no obvious syntax errors are visible at the specified lines.
These warnings are likely false positives, possibly due to the tool's inability to parse the entire file context correctly. As the JSON structure is valid and consistent throughout the file, these warnings can be safely ignored.
To confirm the JSON validity, you can run the following command:
If this command executes without errors, it confirms that the JSON is well-formed.
Also applies to: 657-657
🧰 Tools
🪛 Biome
[error] 458-458: Expected an array, an object, or a literal but instead found ']'.
Expected an array, an object, or a literal here.
(parse)
H3xept
force-pushed
the
sushiswap-approve-dex
branch
2 times, most recently
from
a3d6a1e to
7d6cbeb
Compare
H3xept
force-pushed
the
sushiswap-approve-dex
branch
from
7d6cbeb to
831fd7f
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- config/dexs.json (19 hunks)
🧰 Additional context used
🔇 Additional comments (18)
config/dexs.json (18)
40-43: New addresses added correctly to mainnet.The new addresses have been added correctly to the end of the mainnet array. They are properly formatted and don't appear to be duplicates of existing entries.
83-86: New addresses added correctly to arbitrum.The new addresses have been added correctly to the end of the arbitrum array. They are properly formatted and don't appear to be duplicates of existing entries.
145-148: New addresses added correctly to avalanche.The new addresses have been added correctly to the end of the avalanche array. They are properly formatted and don't appear to be duplicates of existing entries.
171-172: New addresses added correctly to base.The new addresses have been added correctly to the end of the base array. They are properly formatted and don't appear to be duplicates within this network.
207-211: New addresses added correctly to boba.The new addresses have been added correctly to the end of the boba array. They are properly formatted and don't appear to be duplicates of existing entries.
250-253: New addresses added correctly to bsc.The new addresses have been added correctly to the end of the bsc array. They are properly formatted and don't appear to be duplicates of existing entries.
337-340: New addresses added correctly to fantom.The new addresses have been added correctly to the end of the fantom array. They are properly formatted and don't appear to be duplicates of existing entries.
387-390: New addresses added correctly to gnosis.The new addresses have been added correctly to the end of the gnosis array. They are properly formatted and don't appear to be duplicates of existing entries.
463-464: New addresses added correctly to linea.The new addresses have been added correctly to the end of the linea array. They are properly formatted and don't appear to be duplicates of existing entries.
480-481: New addresses added correctly to metis.The new addresses have been added correctly to the end of the metis array. They are properly formatted and don't appear to be duplicates of existing entries.
603-606: New addresses added correctly to optimism.The new addresses have been added correctly to the end of the optimism array. They are properly formatted and don't appear to be duplicates of existing entries.
652-655: New addresses added correctly to polygon.The new addresses have been added correctly to the end of the polygon array. They are properly formatted and don't appear to be duplicates of existing entries.
675-677: New addresses added correctly to polygonzkevm.The new addresses have been added correctly to the end of the polygonzkevm array. They are properly formatted and don't appear to be duplicates of existing entries.
685-687: New addresses added correctly to rootstock.The new addresses have been added correctly to the end of the rootstock array. They are properly formatted and don't appear to be duplicates of existing entries.
357-360:⚠️ Potential issueRemove duplicate address in fuse section.
The address
0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202eon line 358 is already present in the fuse array (line 14). Please remove this duplicate entry to maintain data integrity.Apply this diff to remove the duplicate address:
"fuse": [ ... "0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e", "0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc", - "0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e", "0x1be211D8DA40BC0ae8719c6663307Bfc987b1d6c", "0xaa26771d497814E81D305c511Efbb3ceD90BF5bd", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" ],Likely invalid or redundant comment.
509-511:⚠️ Potential issueRemove duplicate address in moonbeam section.
The address
0xB45e53277a7e0F1D35f2a77160e91e25507f1763on line 509 is already present in the moonbeam array (line 14). Please remove this duplicate entry to maintain data integrity.Apply this diff to remove the duplicate address:
"moonbeam": [ ... "0xc02FFcdD914DbA646704439c6090BAbaD521d04C", - "0xB45e53277a7e0F1D35f2a77160e91e25507f1763", "0x6c5A9e667297b409B5dD9850b38889ab84110c2A", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55", "0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc" ],Likely invalid or redundant comment.
533-536:⚠️ Potential issueRemove duplicate address in moonriver section.
The address
0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202eon line 533 is already present in the moonriver array (line 19). Please remove this duplicate entry to maintain data integrity.Apply this diff to remove the duplicate address:
"moonriver": [ ... "0xc02FFcdD914DbA646704439c6090BAbaD521d04C", - "0x46B3fDF7b5CDe91Ac049936bF0bDb12c5d22202e", "0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc", "0x9e4791ad13f14783C7B2A6A7bD8D6DDD1DC95847", "0x7af71799C40F952237eAA4D81A77C1af49125113", "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" ],Likely invalid or redundant comment.
Line range hint
1-687: Overall review summaryThe changes to the
config/dexs.jsonfile mostly involve adding new addresses to various network sections. The additions are generally correct and maintain the existing structure of the file. However, there are a few instances of duplicate addresses that need to be addressed:
- In the "blast" section (around line 184)
- In the "celo" section (around line 273)
- In the "fuse" section (around line 358)
- In the "moonbeam" section (around line 509)
- In the "moonriver" section (around line 533)
Please review and remove these duplicate entries as suggested in the individual comments. After addressing these issues, the file structure and content will be consistent and free of duplicates.
To ensure all duplicates have been removed and no new ones were introduced, run the following script:
This script will output any duplicate addresses found within each network section. If no output is produced, it means no duplicates were found.
| "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", | ||
| "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" |
There was a problem hiding this comment.
Remove duplicate address in celo section.
The address 0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959 is repeated on lines 273 and 274. Please remove one of these duplicate entries to maintain data integrity.
Apply this diff to remove the duplicate address:
"celo": [
...
"0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc",
"0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959",
- "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959",
"0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55"
],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", | |
| "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" | |
| "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", | |
| "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55" |
| "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", | ||
| "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55", | ||
| "0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc" |
There was a problem hiding this comment.
Remove duplicate address in blast section.
The address 0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959 on line 184 is already present in the blast array (line 8). Please remove this duplicate entry to maintain data integrity.
Apply this diff to remove the duplicate address:
"blast": [
...
"0x0000000000001ff3684f28c67538d4d072c22734",
- "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959",
"0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55",
"0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc"
],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "0xCdBCd51a5E8728E0AF4895ce5771b7d17fF71959", | |
| "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55", | |
| "0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc" | |
| "0xf2614A233c7C3e7f08b1F887Ba133a13f1eb2c55", | |
| "0x6140b987d6B51Fd75b66C3B07733Beb5167c42fc" |
Which Jira task belongs to this PR?
Relates to https://lifi.atlassian.net/browse/LF-10060
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)