-
Notifications
You must be signed in to change notification settings - Fork 51
Add support for Zfinx and Zfh extension #67
Conversation
Signed-off-by: anuani21 <[email protected]>
@neelgala , -Please have your review and let us know if more information would help. |
@neelgala , -Please have your review and let us know if more information would help. |
Signed-off-by: anuani21 <[email protected]>
@allenjbaum,Can you please review this PR for approval? |
I'm not familiar enough with CTG to do a good job of reviewing this (though more comments would help a lot. If you've run this under riscof, and it passes tests with the correct coverage, for RV64 and RV32, with & without D/Dinx configuration, then that's the major thing. Defining coverage is what I want to see, and these extensions have more corner cases to watch out for, especially register assignments, nan-Boxing, etc. |
Hmm - I'm not sure we should still be referring to incoresemi license details for any of tese; that somehow seems wrong (As opposed to the icense terms that most other repos use) |
After some digging, I found this pr, and seems some of the ctg files need changes on
Should be
The related issues are: Maybe some changes are needed? |
Signed-off-by: anuani21 <[email protected]>
Signed-off-by: Umer Shahid <[email protected]>
@anuani21, I have made a commit to resolve the conflicts and to enable the CI. It seems like CI is failing, please take a look at it. |
Ok, I will check and let you know
…On Thu, 18 Jul, 2024, 3:23 pm Umer Shahid, ***@***.***> wrote:
@anuani21 <https://github.com/anuani21>, I have made a commit to resolve
the conflicts and to enable the CI. It seems like CI is failing, please
take a look at it.
—
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3G6FFZYP4N454USVGZQ5STZM6GBNAVCNFSM6AAAAAAZ4AJ6ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZWGA4TQMZZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@UmerShahidengr, Can you please review it and commit |
@anuani21 CI is still failing. I think there is some issue in test generation for rv32 type tests. |
@UmerShahidengr, Can you please review it and commit?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go
Added Support for Zfh and Zfinx extensions
This PR adds