-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused header cleanup #1199
Unused header cleanup #1199
Conversation
f12d1fb
to
02e7408
Compare
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
…sourceManager (ros-controls#1184) Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
…itly set (ros-controls#1192) Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]> Signed-off-by: Henry Moore <[email protected]>
02e7408
to
acc7729
Compare
Sorry about the force pushes, was rebasing to use the correct signing key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now that the CI is finally healthier, let's see how it does here! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
- Coverage 86.58% 86.57% -0.02%
==========================================
Files 95 95
Lines 8586 8586
Branches 719 719
==========================================
- Hits 7434 7433 -1
Misses 883 883
- Partials 269 270 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit 96a8d57) # Conflicts: # joint_state_broadcaster/src/joint_state_broadcaster.cpp # joint_trajectory_controller/test/test_assets.hpp # pid_controller/src/pid_controller.cpp # tricycle_controller/include/tricycle_controller/odometry.hpp
This PR just removes unused headers, replacing them with different ones where necessary. It also standardizes using
#include <gmock/gmock.h>
as opposed to#include "gmock/gmock.h"
(both were being used). Each commit is one package for convenience. The code still builds and the same tests seem to be failing as before. I don't notice any improvement in build speed, so this is just a style change.I used the clangd extension in vscode for this, though had to ignore a select few of its suggestions which caused build failures (particularly with
*_impl.hpp
files and similar.