Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused header cleanup #1199

Merged
merged 25 commits into from
Jul 16, 2024

Conversation

henrygerardmoore
Copy link
Contributor

This PR just removes unused headers, replacing them with different ones where necessary. It also standardizes using #include <gmock/gmock.h> as opposed to #include "gmock/gmock.h" (both were being used). Each commit is one package for convenience. The code still builds and the same tests seem to be failing as before. I don't notice any improvement in build speed, so this is just a style change.

I used the clangd extension in vscode for this, though had to ignore a select few of its suggestions which caused build failures (particularly with *_impl.hpp files and similar.

Henry Moore and others added 22 commits July 10, 2024 20:44
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
Signed-off-by: Henry Moore <[email protected]>
@henrygerardmoore
Copy link
Contributor Author

Sorry about the force pushes, was rebasing to use the correct signing key.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar
Copy link
Member

bmagyar commented Jul 16, 2024

Now that the CI is finally healthier, let's see how it does here!

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (2674f6d) to head (6222d75).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   86.58%   86.57%   -0.02%     
==========================================
  Files          95       95              
  Lines        8586     8586              
  Branches      719      719              
==========================================
- Hits         7434     7433       -1     
  Misses        883      883              
- Partials      269      270       +1     
Flag Coverage Δ
unittests 86.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <ø> (ø)
...roller/test/test_ackermann_steering_controller.hpp 86.59% <ø> (ø)
.../test_ackermann_steering_controller_preceeding.cpp 100.00% <ø> (ø)
.../include/admittance_controller/admittance_rule.hpp 100.00% <ø> (ø)
...ude/admittance_controller/admittance_rule_impl.hpp 93.51% <ø> (ø)
...dmittance_controller/src/admittance_controller.cpp 73.98% <ø> (ø)
...nce_controller/test/test_admittance_controller.cpp 100.00% <ø> (ø)
...nce_controller/test/test_admittance_controller.hpp 94.79% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.11% <ø> (ø)
... and 43 more

... and 1 file with indirect coverage changes

@bmagyar bmagyar merged commit 96a8d57 into ros-controls:master Jul 16, 2024
16 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
(cherry picked from commit 96a8d57)

# Conflicts:
#	joint_state_broadcaster/src/joint_state_broadcaster.cpp
#	joint_trajectory_controller/test/test_assets.hpp
#	pid_controller/src/pid_controller.cpp
#	tricycle_controller/include/tricycle_controller/odometry.hpp
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants