-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: stepper: tmc: create rampgen Kconfig template #83063
Open
jilaypandya
wants to merge
3
commits into
zephyrproject-rtos:main
Choose a base branch
from
jilaypandya:feature/rectify-tmc5041-kconfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
drivers: stepper: tmc: create rampgen Kconfig template #83063
jilaypandya
wants to merge
3
commits into
zephyrproject-rtos:main
from
jilaypandya:feature/rectify-tmc5041-kconfig
+37
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri and
faxe1008
December 16, 2024 17:13
create rampstat Kconfig template to enable respective tmc drivers to reuse the common configurations Signed-off-by: Jilay Pandya <[email protected]>
rename CONFIG_STEPPER_ADI_RAMP_GEN to CONFIG_STEPPER_ADI_TMC5041_RAMP_GEN Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
feature/rectify-tmc5041-kconfig
branch
from
December 16, 2024 19:08
152ae03
to
37e28b6
Compare
jilaypandya
changed the title
drivers: stepper: tmc: create rampstat Kconfig template
drivers: stepper: tmc: create rampgen Kconfig template
Dec 16, 2024
fabiobaltieri
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc: migration guide: 4.1:add deprecation info of STEPPER_ADI_TMC_RAMP_GEN
^
'--- missing space
Already reached 75 characters :) |
dipakgmx
reviewed
Dec 17, 2024
dipakgmx
approved these changes
Dec 17, 2024
kartben
approved these changes
Dec 17, 2024
Is that enforced? I think that's more of a suggestion |
jilaypandya
force-pushed
the
feature/rectify-tmc5041-kconfig
branch
2 times, most recently
from
December 17, 2024 12:53
b03430a
to
68f470e
Compare
…MP_GEN STEPPER_ADI_TMC_RAMP_GEN renamed to template STEPPER_ADI_TMC5041_RAMP_GEN Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
feature/rectify-tmc5041-kconfig
branch
from
December 17, 2024 14:19
68f470e
to
7c5f0df
Compare
bjarki-andreasen
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create rampstat Kconfig template to enable respective tmc drivers to reuse the common configurations
PR to facilitate #80784