-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior kick accuracy #750
Open
schluis
wants to merge
16
commits into
HULKs:main
Choose a base branch
from
schluis:behavior-kick-accuracy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleflb
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No complete review, just had some minutes and skimmed over the code
schluis
force-pushed
the
behavior-kick-accuracy
branch
from
March 20, 2024 10:14
84e4bba
to
17906fb
Compare
schluis
force-pushed
the
behavior-kick-accuracy
branch
from
April 19, 2024 12:39
4311a0c
to
70f66ab
Compare
JackyBloxx
force-pushed
the
behavior-kick-accuracy
branch
from
April 19, 2024 12:53
70f66ab
to
4311a0c
Compare
schluis
force-pushed
the
behavior-kick-accuracy
branch
from
April 19, 2024 13:11
4311a0c
to
948433c
Compare
JackyBloxx
force-pushed
the
behavior-kick-accuracy
branch
from
July 10, 2024 17:43
de82c6b
to
2a40831
Compare
JackyBloxx
force-pushed
the
behavior-kick-accuracy
branch
2 times, most recently
from
July 15, 2024 13:55
38b5ea0
to
fcf2e71
Compare
schluis
force-pushed
the
behavior-kick-accuracy
branch
from
July 19, 2024 08:18
d47619a
to
30ff703
Compare
schluis
commented
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 🚀
disable turn and side kicks during PenaltyShootout tune kick penalty_shootout_reached_thresholds fix behavior simulator refactoring allow explicit_auto_deref for code generation abbreviation use precision_pick_parameters also in other states fix kick-generation & behavior simulator decrease required accuracy added timeout to precison kick added SystemTime as an option Fix behavior simulator Co-authored-by: phillip kammradt <phillip.kammradt@tuhh> fix order of time comparisons Co-authored-by: phillip kammradt <phillip.kammradt@tuhh> muss noch bug fixen und lastfilteredgamecontrolerstatechange eingebaut fix rebase rebase die 2te fix kick variant enabling (HULKs#1181) * fix kick variant enabling * implement clippy hint rebase die 3te precicion_kick_position added Fix Penalized / Initial Pose & reduce stiffness (HULKs#1199) * revert default.json * adjust stiffnesses Deaf ref (HULKs#1192) * Make ref deaf and slightly blind Removes the ears from confidence filtering and demotes the eyes to the lower confidence treshold. Also adds a differentiation between the importance of the points in the twix pose detection overlay, based the confidence threshold of that point. * Reduce visual referee keypoint confidence thresholds Reduce `minimum_overall_keypoint_confidence` and `minimum_visual_referee_keypoint_confidence`. * Revert pose detection toggle hack * Address review comments Calib20240715 (HULKs#1209) * Calib 3 NAOs * Calib 7 NAOs * Move file location reintroduce check (HULKs#1207) Co-authored-by: okiwi6 <oleflb> Fix referee position overlay (HULKs#1228) Fix head joint stiffness (HULKs#1210) Co-authored-by: Julian Schuler <[email protected]> add additional hysteresis_from_thresholds (HULKs#1172) * add additional hysteresis_from_thresholds * use easier to read logic Co-authored-by: Ole Felber <[email protected]> * clippy * typo * add test cases * clippyy * use ranges * use ranges * use all ranges * Update crates/filtering/src/hysteresis.rs Co-authored-by: Maximilian Schmidt <[email protected]> * Update crates/filtering/src/hysteresis.rs Co-authored-by: Maximilian Schmidt <[email protected]> * assert relative ranges * use RangeInclusive * use RangeInclusive * use RangeInclusive * test-found-typo * ahhhhhhhhhhhhh * ahhhhhhhhhhhhhhhhhhhhhhhhhhhh * ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh * renaming * renaming * doc strings * Monospace, monospace text blocks * fix WalkAndStand hysteresis * fix doc-strings --------- Co-authored-by: Ole Felber <[email protected]> Co-authored-by: Maximilian Schmidt <[email protected]> remove accidental parameters object wrap (HULKs#1231) Color Ranges (HULKs#1203) * color ranges * tune parameters * off by one Add --prepare flag for pepsi upload and pregame (HULKs#1198) * Add prepare flag for upload and pregame * Bump pepsi version * Change println! to eprintln! --------- Co-authored-by: Julian Schuler <[email protected]> Reduce `minimum_visual_referee_keypoint_confidence` (HULKs#1232) plot cb and cr in twix (HULKs#1234) Adjust catching steps (HULKs#1206) * add longitudinal offset to catching steps * cleanify * re-enable catching steps Fix saving camera matrix (HULKs#1229) Fix uninitialized cycler databases (HULKs#1202) Co-authored-by: Julian Schuler <[email protected]> Co-authored-by: knoellle <[email protected]> Co-authored-by: Maximilian Schmidt <[email protected]> Bump image and pepsi version (HULKs#1235) * Bump image and pepsi version * Update Cargo.lock only Forward kicks as penalty kicks (HULKs#1204) * remove SideKicks from penalty kick variants Co-authored-by: pejotejo <[email protected]> * add luis comments * address review comments * add kick strength for penalty kick --------- Co-authored-by: pejotejo <[email protected]> Sample more pixels for color calculation of segments (HULKs#1179) implement precision kicks for more rename
schluis
force-pushed
the
behavior-kick-accuracy
branch
from
December 4, 2024 17:06
fabc153
to
e989b0a
Compare
schluis
force-pushed
the
behavior-kick-accuracy
branch
from
December 4, 2024 18:15
e989b0a
to
d0a5d5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
precision_kick_reached_thresholds
forprecision_kicks
Based on #742
Extends #741
How to Test