Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior kick accuracy #750

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

schluis
Copy link
Contributor

@schluis schluis commented Mar 17, 2024

Introduced Changes

  • Introduces new precision_kick_reached_thresholds for precision_kicks

Based on #742
Extends #741

How to Test

  • Check, if the penalty shootout is more accurate

Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complete review, just had some minutes and skimmed over the code

etc/parameters/default.json Outdated Show resolved Hide resolved
crates/control/src/behavior/dribble.rs Outdated Show resolved Hide resolved
@schluis schluis force-pushed the behavior-kick-accuracy branch from 84e4bba to 17906fb Compare March 20, 2024 10:14
@oleflb oleflb modified the milestones: Seasongoal 2024, GermanOpen 2024 Apr 6, 2024
@schluis schluis added this to the Seasongoal 2024 milestone Apr 6, 2024
@schluis schluis added the GO24 label Apr 6, 2024
@schluis schluis force-pushed the behavior-kick-accuracy branch from 4311a0c to 70f66ab Compare April 19, 2024 12:39
@JackyBloxx JackyBloxx force-pushed the behavior-kick-accuracy branch from 70f66ab to 4311a0c Compare April 19, 2024 12:53
@schluis schluis force-pushed the behavior-kick-accuracy branch from 4311a0c to 948433c Compare April 19, 2024 13:11
@schluis schluis disabled auto-merge April 19, 2024 14:09
@schluis schluis assigned schluis and JackyBloxx and unassigned oleflb Apr 19, 2024
@JackyBloxx JackyBloxx force-pushed the behavior-kick-accuracy branch from de82c6b to 2a40831 Compare July 10, 2024 17:43
@MaikRe MaikRe added RC24 and removed GO24 labels Jul 11, 2024
@JackyBloxx JackyBloxx force-pushed the behavior-kick-accuracy branch 2 times, most recently from 38b5ea0 to fcf2e71 Compare July 15, 2024 13:55
@schluis schluis force-pushed the behavior-kick-accuracy branch from d47619a to 30ff703 Compare July 19, 2024 08:18
Copy link
Contributor Author

@schluis schluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚀

crates/control/src/behavior/dribble.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/dribble.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/dribble.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/dribble.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/dribble.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/node.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/node.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/node.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/node.rs Outdated Show resolved Hide resolved
crates/control/src/behavior/node.rs Outdated Show resolved Hide resolved
@schluis schluis enabled auto-merge July 20, 2024 21:42
@schluis schluis disabled auto-merge July 20, 2024 21:42
@schluis schluis removed the RC24 label Jul 31, 2024
schluis and others added 14 commits December 4, 2024 17:29
disable turn and side kicks during PenaltyShootout

tune kick penalty_shootout_reached_thresholds

fix behavior simulator

refactoring

allow explicit_auto_deref for code generation

abbreviation

use precision_pick_parameters also in other states

fix kick-generation & behavior simulator

decrease required accuracy

added timeout to precison kick

added SystemTime as an option

Fix behavior simulator

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>

fix order of time comparisons

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>

muss noch bug fixen und lastfilteredgamecontrolerstatechange eingebaut

fix

rebase

rebase die 2te

fix kick variant enabling (HULKs#1181)

* fix kick variant enabling

* implement clippy hint

rebase die 3te

precicion_kick_position added

Fix Penalized / Initial Pose & reduce stiffness (HULKs#1199)

* revert default.json

* adjust stiffnesses

Deaf ref (HULKs#1192)

* Make ref deaf and slightly blind

Removes the ears from confidence filtering and demotes the eyes to the lower confidence treshold. Also adds a differentiation between the importance of the points in the twix pose detection overlay, based the confidence threshold of that point.

* Reduce visual referee keypoint confidence thresholds

Reduce `minimum_overall_keypoint_confidence` and `minimum_visual_referee_keypoint_confidence`.

* Revert pose detection toggle hack

* Address review comments

Calib20240715 (HULKs#1209)

* Calib 3 NAOs

* Calib 7 NAOs

* Move file location

reintroduce check (HULKs#1207)

Co-authored-by: okiwi6 <oleflb>

Fix referee position overlay (HULKs#1228)

Fix head joint stiffness (HULKs#1210)

Co-authored-by: Julian Schuler <[email protected]>

add additional hysteresis_from_thresholds (HULKs#1172)

* add additional hysteresis_from_thresholds

* use easier to read logic

Co-authored-by: Ole Felber <[email protected]>

* clippy

* typo

* add test cases

* clippyy

* use ranges

* use ranges

* use all ranges

* Update crates/filtering/src/hysteresis.rs

Co-authored-by: Maximilian Schmidt <[email protected]>

* Update crates/filtering/src/hysteresis.rs

Co-authored-by: Maximilian Schmidt <[email protected]>

* assert relative ranges

* use RangeInclusive

* use RangeInclusive

* use RangeInclusive

* test-found-typo

* ahhhhhhhhhhhhh

* ahhhhhhhhhhhhhhhhhhhhhhhhhhhh

* ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

* renaming

* renaming

* doc strings

* Monospace, monospace text blocks

* fix WalkAndStand hysteresis

* fix doc-strings

---------

Co-authored-by: Ole Felber <[email protected]>
Co-authored-by: Maximilian Schmidt <[email protected]>

remove accidental parameters object wrap (HULKs#1231)

Color Ranges (HULKs#1203)

* color ranges

* tune parameters

* off by one

Add --prepare flag for pepsi upload and pregame (HULKs#1198)

* Add prepare flag for upload and pregame

* Bump pepsi version

* Change println! to eprintln!

---------

Co-authored-by: Julian Schuler <[email protected]>

Reduce `minimum_visual_referee_keypoint_confidence` (HULKs#1232)

plot cb and cr in twix (HULKs#1234)

Adjust catching steps (HULKs#1206)

* add longitudinal offset to catching steps

* cleanify

* re-enable catching steps

Fix saving camera matrix (HULKs#1229)

Fix uninitialized cycler databases (HULKs#1202)

Co-authored-by: Julian Schuler <[email protected]>
Co-authored-by: knoellle <[email protected]>
Co-authored-by: Maximilian Schmidt <[email protected]>

Bump image and pepsi version (HULKs#1235)

* Bump image and pepsi version

* Update Cargo.lock

only Forward kicks as penalty kicks (HULKs#1204)

* remove SideKicks from penalty kick variants

Co-authored-by: pejotejo <[email protected]>

* add luis comments

* address review comments

* add kick strength for penalty kick

---------

Co-authored-by: pejotejo <[email protected]>

Sample more pixels for color calculation of segments (HULKs#1179)

implement precision kicks for more

rename
@schluis schluis force-pushed the behavior-kick-accuracy branch from fabc153 to e989b0a Compare December 4, 2024 17:06
@schluis schluis enabled auto-merge December 4, 2024 17:07
@schluis schluis force-pushed the behavior-kick-accuracy branch from e989b0a to d0a5d5c Compare December 4, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Request for Review
Development

Successfully merging this pull request may close these issues.

4 participants