-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing the from nailgun import entities and moving target_sat, module_target_sat #12989
removing the from nailgun import entities and moving target_sat, module_target_sat #12989
Conversation
eadb6f7
to
6d0d032
Compare
5bf67a0
to
ca1dee2
Compare
ca1dee2
to
c018f83
Compare
trigger: test-robottelo |
c018f83
to
8d221f5
Compare
trigger: test-robottelo |
@shweta83 @vsedmik @pondrejk @Griffin-Sullivan Can you please also take a look from the components side as it is touching multiple component tests. |
@omkarkhatavkar Great job, thanks for this refactor ❤️ |
@omkarkhatavkar Changes impacting Rocket team components are good. Ack for the rocket team tests except for @Gauravtalreja1 comment. |
@Gauravtalreja1 It will be the seperate PR's as It will be easy to test it out and also review will be smoother |
8d221f5
to
b066ed1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, none of these components are owned by Platform. Everything looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Nice work
803cbb4
to
dc18255
Compare
Hi @JacobCallahan and @vijaysawant, please review. Once confirmed, we can merge without frequent rebases. Thanks! |
Key Changes:
Direct Imports Removed: We've cleaned up our codebase by eliminating direct imports from the nailgun package.
Using target_sat, module_target_sat, class_target_sat: Modified the API calls and using the
target_sat.api.
pattern for all API calls.