Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the from nailgun import entities and moving target_sat, module_target_sat #12989

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

omkarkhatavkar
Copy link

@omkarkhatavkar omkarkhatavkar commented Oct 26, 2023

Key Changes:

  • Direct Imports Removed: We've cleaned up our codebase by eliminating direct imports from the nailgun package.

  • Using target_sat, module_target_sat, class_target_sat: Modified the API calls and using the target_sat.api. pattern for all API calls.

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner October 26, 2023 10:59
@omkarkhatavkar omkarkhatavkar marked this pull request as draft October 26, 2023 10:59
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Oct 26, 2023
@omkarkhatavkar omkarkhatavkar changed the title removing the from nailgun import entities and moving target_sat, module_target_sat [WIP] - removing the from nailgun import entities and moving target_sat, module_target_sat Oct 26, 2023
@omkarkhatavkar omkarkhatavkar force-pushed the update_target_sat branch 6 times, most recently from 5bf67a0 to ca1dee2 Compare October 26, 2023 14:56
@omkarkhatavkar omkarkhatavkar changed the title [WIP] - removing the from nailgun import entities and moving target_sat, module_target_sat removing the from nailgun import entities and moving target_sat, module_target_sat Oct 29, 2023
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@omkarkhatavkar omkarkhatavkar marked this pull request as ready for review October 30, 2023 10:15
@omkarkhatavkar
Copy link
Author

@shweta83 @vsedmik @pondrejk @Griffin-Sullivan Can you please also take a look from the components side as it is touching multiple component tests.

@omkarkhatavkar omkarkhatavkar requested a review from a team October 30, 2023 10:29
@Gauravtalreja1
Copy link
Collaborator

@omkarkhatavkar Great job, thanks for this refactor ❤️
Could you add changes for updating fixtures, and setup part done by nailgun entities in CLI/UI/destructive/etc modules too? or are you intending to open a separate PR for each?

@shweta83
Copy link
Contributor

@omkarkhatavkar Changes impacting Rocket team components are good. Ack for the rocket team tests except for @Gauravtalreja1 comment.

@omkarkhatavkar
Copy link
Author

@omkarkhatavkar Great job, thanks for this refactor ❤️ Could you add changes for updating fixtures, and setup part done by nailgun entities in CLI/UI/destructive/etc modules too? or are you intending to open a separate PR for each?

@Gauravtalreja1 It will be the seperate PR's as It will be easy to test it out and also review will be smoother

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, none of these components are owned by Platform. Everything looks good to me!

Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work

@omkarkhatavkar
Copy link
Author

Hi @JacobCallahan and @vijaysawant, please review. Once confirmed, we can merge without frequent rebases. Thanks!

@JacobCallahan JacobCallahan merged commit 01aeddd into SatelliteQE:master Nov 7, 2023
5 checks passed
@pondrejk pondrejk mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants